[Asterisk-code-review] install prereq: Split into multiple scripts and data. (asterisk[master])

Corey Farrell asteriskteam at digium.com
Wed Mar 21 19:00:35 CDT 2018


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/8516 )

Change subject: install_prereq: Split into multiple scripts and data.
......................................................................


Patch Set 3:

> Give that is sounds like there is multiple ways of installing these
 > dependencies, internal tooling, docker, this.  You could move the
 > packages from outside of these scripts and start standardizing them
 > into bindep.txt.  Yes, bindep would then be installed but rather
 > then updating each package dependencies in multiple places, it
 > would become a single location.
 > 
 > I can understand if you dont' want to use that in your tooling, but
 > find bindep works very well in the openstack project for managing
 > OS dependencies over just listing them in multiple bash files. 
 > Especially since suse and redhat likey have some shared package
 > names, it would help reduce the copypasta.

George said he has something they use to setup jenkins agents which he is planning to post, I just wanted to post what the updates to this so it wouldn't be in a merge conflict state.  I will defer to others for deciding what should be done from here.


-- 
To view, visit https://gerrit.asterisk.org/8516
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16a26b19047a8b3da3947c7953cd104241b7472d
Gerrit-Change-Number: 8516
Gerrit-PatchSet: 3
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Paul Belanger <pabelanger at gmail.com>
Gerrit-Comment-Date: Thu, 22 Mar 2018 00:00:35 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180321/1d6d63d9/attachment.html>


More information about the asterisk-code-review mailing list