[Asterisk-code-review] pjsip/sdp offer answer: Add test for presence of 'goog-remb'. (testsuite[15])

Jenkins2 asteriskteam at digium.com
Wed Mar 21 14:00:13 CDT 2018


Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/8602 )

Change subject: pjsip/sdp_offer_answer: Add test for presence of 'goog-remb'.
......................................................................

pjsip/sdp_offer_answer: Add test for presence of 'goog-remb'.

This adds a WebRTC SDP offer answer test which confirms that
for video streams we place a goog-remb rtcp-fb attribute into
the SDP.

Change-Id: Ic8c50e2edbc418bb753cdec7b10aab96e4d5d345
---
M tests/channels/pjsip/sdp_offer_answer/tests.yaml
A tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/configs/ast1/extensions.conf
A tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/configs/ast1/pjsip.conf
A tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/sipp/reject.xml
A tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/test-config.yaml
A tests/channels/pjsip/sdp_offer_answer/webrtc/tests.yaml
6 files changed, 104 insertions(+), 0 deletions(-)

Approvals:
  George Joseph: Looks good to me, but someone else must approve
  Kevin Harwell: Looks good to me, approved
  Jenkins2: Approved for Submit



diff --git a/tests/channels/pjsip/sdp_offer_answer/tests.yaml b/tests/channels/pjsip/sdp_offer_answer/tests.yaml
index b0e0de9..db42d34 100644
--- a/tests/channels/pjsip/sdp_offer_answer/tests.yaml
+++ b/tests/channels/pjsip/sdp_offer_answer/tests.yaml
@@ -2,3 +2,4 @@
 tests:
     - dir: 'incoming'
     - dir: 'attribute_passthrough'
+    - dir: 'webrtc'
diff --git a/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/configs/ast1/extensions.conf b/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/configs/ast1/extensions.conf
new file mode 100644
index 0000000..9897089
--- /dev/null
+++ b/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/configs/ast1/extensions.conf
@@ -0,0 +1,3 @@
+[default]
+exten => nowhere,1,NoOp()
+exten => webrtc,1,Dial(PJSIP/webrtc)
diff --git a/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/configs/ast1/pjsip.conf b/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/configs/ast1/pjsip.conf
new file mode 100644
index 0000000..0d794df
--- /dev/null
+++ b/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/configs/ast1/pjsip.conf
@@ -0,0 +1,25 @@
+[global]
+type=global
+debug=yes
+
+[local-transport-udp]
+type=transport
+bind=127.0.0.1
+protocol=udp
+
+[endpoint-template](!)
+type=endpoint
+context=default
+media_address=127.0.0.1
+direct_media=no
+webrtc=yes
+
+[webrtc](endpoint-template)
+aors=webrtc
+disallow=all
+allow=ulaw
+allow=vp9
+
+[webrtc]
+type=aor
+contact=sip:127.0.0.1:5061
diff --git a/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/sipp/reject.xml b/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/sipp/reject.xml
new file mode 100644
index 0000000..ed5f438
--- /dev/null
+++ b/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/sipp/reject.xml
@@ -0,0 +1,31 @@
+<?xml version="1.0" encoding="ISO-8859-1" ?>
+<!DOCTYPE scenario SYSTEM "sipp.dtd">
+
+<scenario name="Receive a WebRTC INVITE with goog-remb">
+	<recv request="INVITE" crlf="true">
+		<action>
+			<ereg regexp="a=rtcp-fb:\* goog-remb"
+			      search_in="body" check_it="true" assign_to="1"/>
+			<strcmp assign_to="1" variable="1" value=""/>
+
+		</action>
+	</recv>
+
+	<send>
+		<![CDATA[
+
+        SIP/2.0 486 Busy Here
+        [last_Via:]
+        [last_From:]
+        [last_To:];tag=[call_number]
+        [last_Call-ID:]
+        [last_CSeq:]
+        Contact: <sip:[local_ip]:[local_port];transport=[transport]>
+        Content-Length: 0
+
+        ]]>
+	</send>
+
+	<recv request="ACK" optional="false" />
+
+</scenario>
diff --git a/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/test-config.yaml b/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/test-config.yaml
new file mode 100644
index 0000000..833ac86
--- /dev/null
+++ b/tests/channels/pjsip/sdp_offer_answer/webrtc/goog-remb/test-config.yaml
@@ -0,0 +1,41 @@
+testinfo:
+    summary: 'Test SDP rtcp-fb attribute negotiation of goog-remb'
+    description: |
+        This tests that when webrtc support is enabled goog-remb is present in the SDP.
+
+test-modules:
+    test-object:
+        config-section: sipp-config
+        typename: sipp.SIPpTestCase
+    modules:
+        -
+            config-section: originator-config
+            typename: pluggable_modules.Originator
+
+sipp-config:
+    memcheck-delay-stop: 7
+    stop-after-scenarios: true
+    test-iterations:
+        -
+            scenarios:
+                - { 'key-args': {'scenario': 'reject.xml', '-i': '127.0.0.1', '-p': '5061' }}
+
+originator-config:
+    channel: 'Local/webrtc at default'
+    ignore-originate-failure: 'yes'
+    context: 'default'
+    exten: 'nowhere'
+    priority: '1'
+    trigger: 'scenario_start'
+    scenario-name: 'reject.xml'
+
+properties:
+    dependencies:
+        - sipp :
+            version : 'v3.0'
+        - asterisk : 'res_pjsip'
+        - asterisk : 'res_pjsip_session'
+        - asterisk : 'res_pjsip_sdp_rtp'
+        - asterisk : 'chan_pjsip'
+    tags:
+        - pjsip
diff --git a/tests/channels/pjsip/sdp_offer_answer/webrtc/tests.yaml b/tests/channels/pjsip/sdp_offer_answer/webrtc/tests.yaml
new file mode 100644
index 0000000..c59597f
--- /dev/null
+++ b/tests/channels/pjsip/sdp_offer_answer/webrtc/tests.yaml
@@ -0,0 +1,3 @@
+# Enter tests here in the order they should be considered for execution:
+tests:
+    - test: 'goog-remb'

-- 
To view, visit https://gerrit.asterisk.org/8602
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 15
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic8c50e2edbc418bb753cdec7b10aab96e4d5d345
Gerrit-Change-Number: 8602
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180321/88bbb4a7/attachment.html>


More information about the asterisk-code-review mailing list