[Asterisk-code-review] BuildSystem: Allow fetch of PJProject without trust anchors. (asterisk[13])
Sean Bright
asteriskteam at digium.com
Wed Mar 21 11:50:37 CDT 2018
Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/8182 )
Change subject: BuildSystem: Allow fetch of PJProject without trust anchors.
......................................................................
Patch Set 4:
(3 comments)
I'd be open to the idea that this could be controlled with an additional flag to configure or an environment variable, but this should not be done by default.
https://gerrit.asterisk.org/#/c/8182/4/configure.ac
File configure.ac:
https://gerrit.asterisk.org/#/c/8182/4/configure.ac@294
PS4, Line 294: DOWNLOAD=${WGET}
Why not here?
https://gerrit.asterisk.org/#/c/8182/4/configure.ac@299
PS4, Line 299: DOWNLOAD_TO_STDOUT="${CURL} -Ls"
Why not here?
https://gerrit.asterisk.org/#/c/8182/4/configure.ac@304
PS4, Line 304: DOWNLOAD=${FETCH}
Why not here?
--
To view, visit https://gerrit.asterisk.org/8182
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I573308fa11a69d28480b669971b5bfe66476fa60
Gerrit-Change-Number: 8182
Gerrit-PatchSet: 4
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Wed, 21 Mar 2018 16:50:37 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180321/f3f9b8a4/attachment.html>
More information about the asterisk-code-review
mailing list