[Asterisk-code-review] bridge softmix: Clear "talking" when a channel is put on hold (asterisk[13])

Joshua Colp asteriskteam at digium.com
Wed Mar 21 05:35:19 CDT 2018


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/8614 )

Change subject: bridge_softmix: Clear "talking" when a channel is put on hold
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/8614/1/bridges/bridge_softmix.c
File bridges/bridge_softmix.c:

https://gerrit.asterisk.org/#/c/8614/1/bridges/bridge_softmix.c@688
PS1, Line 688: 	if (sc->talking) {
You could just return early here and reduce indentation.



-- 
To view, visit https://gerrit.asterisk.org/8614
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I930e16c4662810f9f02043d69062f88173c5e2ef
Gerrit-Change-Number: 8614
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Wed, 21 Mar 2018 10:35:19 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180321/7b18c155/attachment.html>


More information about the asterisk-code-review mailing list