[Asterisk-code-review] named acl: Use ast cli completion add. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8595 )

Change subject: named_acl: Use ast_cli_completion_add.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/8595/1/main/named_acl.c
File main/named_acl.c:

https://gerrit.asterisk.org/#/c/8595/1/main/named_acl.c@518
PS1, Line 518: 		cfg = ao2_global_obj_ref(globals);
Since we only can have one optional ACL name we should add the below check before this line:

if (a->pos != 2) {
   return NULL;
}



-- 
To view, visit https://gerrit.asterisk.org/8595
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I317a82de976bbdbfe4352c243e32a7bb8f66c377
Gerrit-Change-Number: 8595
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 19 Mar 2018 20:59:03 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180319/cf6c40ec/attachment.html>