[Asterisk-code-review] manager: Use ast cli completion add for completion generators. (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8592 )

Change subject: manager: Use ast_cli_completion_add for completion generators.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/8592/1/main/manager.c
File main/manager.c:

https://gerrit.asterisk.org/#/c/8592/1/main/manager.c@2329
PS1, Line 2329: 	int num, l;
Might as well make one declaration per line.


https://gerrit.asterisk.org/#/c/8592/1/main/manager.c@8645
PS1, Line 8645: 		length = strlen(a->word);
Preexisting bug.

Need to add this check like in handle_showmanager() because the command only allows one <eventname> to be listed:

if (a->pos != 3) {
   return NULL;
}



-- 
To view, visit https://gerrit.asterisk.org/8592
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I658141c6ec490a3e866b02d2afea757928ceaabf
Gerrit-Change-Number: 8592
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 19 Mar 2018 19:39:11 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180319/4b0d1519/attachment.html>