[Asterisk-code-review] app dial: Enable early-media video (asterisk[15])

Jenkins2 asteriskteam at digium.com
Mon Mar 19 09:06:18 CDT 2018


Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/8397 )

Change subject: app_dial: Enable early-media video
......................................................................

app_dial: Enable early-media video

Certain applications (e.g. door-phone) require that also video is transmitted
before a call is accepted.

Change-Id: I9842e1dc2f6e1c2c49dc33fe615255007d2f821e
---
M UPGRADE.txt
M apps/app_dial.c
2 files changed, 10 insertions(+), 0 deletions(-)

Approvals:
  Richard Mudgett: Looks good to me, but someone else must approve
  Joshua Colp: Looks good to me, approved
  Jenkins2: Approved for Submit



diff --git a/UPGRADE.txt b/UPGRADE.txt
index 0a33ff0..436570c 100644
--- a/UPGRADE.txt
+++ b/UPGRADE.txt
@@ -23,6 +23,14 @@
 === UPGRADE-14.txt  -- Upgrade info for 13 to 14
 ===========================================================
 
+From 15.3.0 to 15.4.0:
+
+app_dial
+------------------
+ * The Dial application now supports early-media video (in addition to
+   audio) on both the calling as well as the called party.
+   Be aware that this is a change in behavior.
+
 From 15.2.0 to 15.3.0:
 
 app_confbridge
diff --git a/apps/app_dial.c b/apps/app_dial.c
index b9f9dcb..d78ba53 100644
--- a/apps/app_dial.c
+++ b/apps/app_dial.c
@@ -1601,6 +1601,7 @@
 					break;
 				}
 				break;
+			case AST_FRAME_VIDEO:
 			case AST_FRAME_VOICE:
 			case AST_FRAME_IMAGE:
 				if (caller_entertained) {
@@ -1699,6 +1700,7 @@
 						ast_log(LOG_WARNING, "Unable to send URL\n");
 					}
 					break;
+				case AST_FRAME_VIDEO:
 				case AST_FRAME_VOICE:
 				case AST_FRAME_IMAGE:
 					if (!single || caller_entertained) {

-- 
To view, visit https://gerrit.asterisk.org/8397
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: merged
Gerrit-Change-Id: I9842e1dc2f6e1c2c49dc33fe615255007d2f821e
Gerrit-Change-Number: 8397
Gerrit-PatchSet: 4
Gerrit-Owner: Florian Floimair <f.floimair at commend.com>
Gerrit-Reviewer: Florian Floimair <f.floimair at commend.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180319/c74d818a/attachment.html>


More information about the asterisk-code-review mailing list