[Asterisk-code-review] core: Stop using AST INLINE API for allocator functions. (asterisk[master])

Corey Farrell asteriskteam at digium.com
Mon Mar 19 00:14:27 CDT 2018


Hello Richard Mudgett, Jenkins2, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/8521

to look at the new patch set (#8).

Change subject: core: Stop using AST_INLINE_API for allocator functions.
......................................................................

core: Stop using AST_INLINE_API for allocator functions.

This replaces AST_INLINE_API allocators in utils.h with real functions
implemented in astmm.c.  Associated macro's are also moved from utils.h
to astmm.h.

Remove menuselect conflicts between MALLOC_DEBUG and DEBUG_CHAOS as they
can now be combined.

This has multiple benefits:
* Simplifies asterisk/utils.h by removing inline functions and use of
  the logger.
* Removal of these inline functions decreases size of Asterisk and
  module binaries by 1% or more.
* Puts memory management functions together with and without
  MALLOC_DEBUG enabled, simplifying management of the code.
* Enables DEBUG_CHAOS for ASTMM_REDIRECT and bundled pjproject.

Change-Id: If9df4377f74bdbb627461b27a473123e05525887
---
M build_tools/cflags.xml
M include/asterisk.h
M include/asterisk/astmm.h
M include/asterisk/utils.h
M main/astmm.c
M third-party/pjproject/patches/asterisk_malloc_debug.h
M utils/.gitignore
M utils/Makefile
M utils/ael_main.c
M utils/astman.c
M utils/check_expr.c
M utils/conf2ael.c
M utils/extconf.c
13 files changed, 409 insertions(+), 667 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/21/8521/8
-- 
To view, visit https://gerrit.asterisk.org/8521
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If9df4377f74bdbb627461b27a473123e05525887
Gerrit-Change-Number: 8521
Gerrit-PatchSet: 8
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180319/2d263b4d/attachment.html>


More information about the asterisk-code-review mailing list