[Asterisk-code-review] core: Backport compatible MALLOC DEBUG changes. (asterisk[15])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8525 )

Change subject: core: Backport compatible MALLOC_DEBUG changes.
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

https://gerrit.asterisk.org/#/c/8525/2/main/astmm.c
File main/astmm.c:

https://gerrit.asterisk.org/#/c/8525/2/main/astmm.c@219
PS2, Line 219: 	DEBUG_CHAOS_RETURN(DEBUG_CHAOS_ALLOC_CHANCE, NULL);
> Just to clarify though, you do not want it to be possible to combine DEBUG_
I wasn't sure how DEBUG_CHAOS_RETURN() was getting defined in this file if it even was defined.  I see now that the strings.h file includes utils.h.

I suppose it is OK to remove the restriction.  I just thought it was more of a side benefit of the master MALLOC_DEBUG patch.  DEBUG_CHAOS has very limited usefulness as only a developer would want to use it for testing purposes.


https://gerrit.asterisk.org/#/c/8525/2/utils/.gitignore
File utils/.gitignore:

https://gerrit.asterisk.org/#/c/8525/2/utils/.gitignore@6
PS2, Line 6: astmm.c
> The point of this is so when you have a non-clean copy of master and checko
Makes sense



-- 
To view, visit https://gerrit.asterisk.org/8525
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f27ced4ce3cbe4b39547a67f994fdff491978c0
Gerrit-Change-Number: 8525
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Sun, 18 Mar 2018 14:19:50 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180318/94578fd7/attachment.html>