[Asterisk-code-review] core: Backport compatible MALLOC DEBUG changes. (asterisk[15])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8525 )

Change subject: core: Backport compatible MALLOC_DEBUG changes.
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/8525/2/main/astmm.c
File main/astmm.c:

https://gerrit.asterisk.org/#/c/8525/2/main/astmm.c@a656
PS2, Line 656: 
I think the only thing this patch should do is fix this and nothing else since the other changes really shouldn't be backported.


https://gerrit.asterisk.org/#/c/8525/2/main/astmm.c@219
PS2, Line 219: 	DEBUG_CHAOS_RETURN(DEBUG_CHAOS_ALLOC_CHANCE, NULL);
This is defined in utils.h.  It isn't directly included by astmm.c.


https://gerrit.asterisk.org/#/c/8525/2/utils/.gitignore
File utils/.gitignore:

https://gerrit.asterisk.org/#/c/8525/2/utils/.gitignore@6
PS2, Line 6: astmm.c
This change shouldn't be in this patch since astmm.c is not copied by the Makefile into the directory.



-- 
To view, visit https://gerrit.asterisk.org/8525
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f27ced4ce3cbe4b39547a67f994fdff491978c0
Gerrit-Change-Number: 8525
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 16 Mar 2018 21:42:17 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180316/2276a5ed/attachment.html>