[Asterisk-code-review] BuildSystem: Add the tool ftp to alternatively download exte... (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/8495 )

Change subject: BuildSystem: Add the tool ftp to alternatively download external parts.
......................................................................


Patch Set 1: Code-Review-1

> Limitation is difficult. Because ftp could support HTTP. Or it
 > could not, for example on FreeBSD (which does not matter because it
 > has fetch for sure). We do not know before. At least I do not know
 > how to differentiate those.
 > 
 > It is expected that no Linux user ever runs into that case because
 > wget or curl is installed. Anyway, it is not a ‘change’ compared to
 > the current state because that double-check, whether a download app
 > is installed, did work before at all. So this adds another final
 > catch which is currently only OpenBSD and NetBSD because all other
 > platforms I tested end up earlier.
 > 
 > In other words: For a user, nothing changes even if he does not
 > have any of those. If he has ftp without HTTP, it did not work for
 > him before.

sounds/Makefile has a rule which catches $(DOWNLOAD) = ':', displays an error telling the user how to work around the issue.


-- 
To view, visit https://gerrit.asterisk.org/8495
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf9120a918bec75d5a571c0f0c9b7f2eec636f87
Gerrit-Change-Number: 8495
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Wed, 14 Mar 2018 14:47:19 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180314/f9ec78f7/attachment.html>