[Asterisk-code-review] install prereq: Split into multiple scripts and data. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/8516 )

Change subject: install_prereq: Split into multiple scripts and data.
......................................................................


Patch Set 1:

> Yes, in the very last step my goal was to re-organise the script as
 > well. I like your idea to split the various distributions. Kudos
 > for that. My goal was actually different: I want to
 > A) spilt the script into ‘essential’ (= build system plus essential
 > plus tool patch) versus ‘all’ (= optional plus unpackaged).
 > B) remove the requirement on wget (make it wget, curl, fetch, ftp
 > as well).
 > 
 > Consequently, I do not like the filename ‘mandatory’. But the rest
 > looks good, very good to me.

The idea is that support for loading 'optional' packages would be a follow-up patch, when that is done some packages would be moved from *.mandatory to the similarly named *.optional file.  The install_prereq would build an optional package list from ${PREREQDIR}/${PREREQPLATFORM}.optional.  I don't have an issue with renaming *.mandatory to *.essential, I will do that when I update this review.

I'm not sure the best way for install_prereq to handle arguments to disabling installing optional stuff.  Really this is something which would need to be decided before splitting the package lists into essential+optional lists.  One comment I think it would be important to allow installing all packages only (ie include optional but not unpackaged).

B) about the ability to choose between download tools I'm not sure how that could be done while keeping the tool simple, but I think this platform based split-up should happen before additional complexity is added.


-- 
To view, visit https://gerrit.asterisk.org/8516
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I16a26b19047a8b3da3947c7953cd104241b7472d
Gerrit-Change-Number: 8516
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Wed, 14 Mar 2018 09:05:33 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180314/819ef6d7/attachment.html>