[Asterisk-code-review] channels/pjsip/basic calls/outgoing/nominal/early media: tes... (testsuite[master])

Richard Mudgett asteriskteam at digium.com
Mon Mar 12 15:05:10 CDT 2018


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8303 )

Change subject: channels/pjsip/basic_calls/outgoing/nominal/early_media: test forked early media
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/8303/3/tests/channels/pjsip/basic_calls/outgoing/nominal/early_media/sipp/ua1_invite_recv.xml
File tests/channels/pjsip/basic_calls/outgoing/nominal/early_media/sipp/ua1_invite_recv.xml:

https://gerrit.asterisk.org/#/c/8303/3/tests/channels/pjsip/basic_calls/outgoing/nominal/early_media/sipp/ua1_invite_recv.xml@76
PS3, Line 76:       [last_To:];tag=[pid]SIPpForkTag01[call_number]
Adding the tag here results in two tags on the header.

Adding the tag to the INVITE responses is necessary because Asterisk doesn't know the receiver's To tag when sending the initial INVITE.  However, the tag is now in the last_To because the BYE has it and that was the last To header received.



-- 
To view, visit https://gerrit.asterisk.org/8303
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I62accd4f993a6f42c77661e4943c1e9df5fbe04c
Gerrit-Change-Number: 8303
Gerrit-PatchSet: 3
Gerrit-Owner: lvl <digium at lvlconsultancy.nl>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 12 Mar 2018 20:05:10 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180312/57515408/attachment-0001.html>


More information about the asterisk-code-review mailing list