[Asterisk-code-review] core: Remove non-critical cleanup from startup aborts. (asterisk[15])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8499 )

Change subject: core: Remove non-critical cleanup from startup aborts.
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

Minor nit.  Acceptable otherwise.

https://gerrit.asterisk.org/#/c/8499/2/main/media_cache.c
File main/media_cache.c:

https://gerrit.asterisk.org/#/c/8499/2/main/media_cache.c@648
PS2, Line 648: 	ao2_ref(media_cache, -1);
For safety this should be an ao2_cleanup().

This was a bug before your patch when ast_media_cache_init() called ao2_ref() on media_cache when it exited with failure and media_cache_shutdown() was registered to run atexit.



-- 
To view, visit https://gerrit.asterisk.org/8499
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Iecc2df98008b21509925ff16740bd5fa29527db3
Gerrit-Change-Number: 8499
Gerrit-PatchSet: 2
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 12 Mar 2018 17:28:46 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180312/59a20366/attachment.html>