[Asterisk-code-review] BuildSystem: Enable OSS Audio Emulation Library in NetBSD. (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/8444 )

Change subject: BuildSystem: Enable OSS Audio Emulation Library in NetBSD.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/8444/1/configure.ac
File configure.ac:

https://gerrit.asterisk.org/#/c/8444/1/configure.ac@2150
PS1, Line 2150: # possible places for OSS definitions
              : # Linux
              : AST_EXT_LIB_CHECK([OSS], [ossaudio], [], [linux/soundcard.h])
              : # NetBSD: Search for a symbol like _oss_ioctl, to link its OSS Audio Emulation Library.
              : AST_EXT_LIB_CHECK([OSS], [ossaudio], [_oss_ioctl], [sys/soundcard.h])
              : # FreeBSD
              : AST_EXT_LIB_CHECK([OSS], [ossaudio], [], [sys/soundcard.h])
              : # OpenBSD
              : AST_EXT_LIB_CHECK([OSS], [ossaudio], [oss_ioctl_mixer], [soundcard.h])
> No, that emulation API might exist on other platforms as well.
Every compile/link test makes the configure script take longer.  If other platforms have this problem another patch can be done to include that platform for the additional checks.  We don't need to make the configure script take even longer because of some theoretical non-Linux platform.

Keep in mind this (and many others) are optional libraries, so checking for the Linux location first does not always eliminate the additional checks.



-- 
To view, visit https://gerrit.asterisk.org/8444
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia230d075218551a2f53171c1b37c211914d03268
Gerrit-Change-Number: 8444
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Sun, 11 Mar 2018 18:34:22 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180311/92dd84e4/attachment.html>