[Asterisk-code-review] loader: Convert reload classes to built-in modules. (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/8390 )

Change subject: loader: Convert reload_classes to built-in modules.
......................................................................


Patch Set 1:

My power and internet is still out since the storm and for some reason Gerrit won't let me add a comment to the code line from my phone.  About built-in modules aborting, they abort asterisk startup unconditionally.  This is the big difference from chan_sip or other regular modules failing, those are recoverable errors and asterisk may try them again.

Anyways I just wanted to mention this so maybe you can reconsider the need for these cleanup calls.  Personally I think these cleanup calls should be removed from 13/15 as well, we never test these cleanups from the partially initialized state, a problem could cause actual important cleanups from running (ast_register_atexit stuff).


-- 
To view, visit https://gerrit.asterisk.org/8390
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I371a9a45064f20026c492623ea8062d02a1ab97f
Gerrit-Change-Number: 8390
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 09 Mar 2018 14:00:32 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180309/8e85794d/attachment.html>