[Asterisk-code-review] BuildSystem: For consistency, avoid double-checking via if c... (asterisk[master])

Alexander Traud asteriskteam at digium.com
Fri Mar 9 03:19:20 CST 2018


Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/8492 )

Change subject: BuildSystem: For consistency, avoid double-checking via if clauses.
......................................................................


Patch Set 1:

This looks like nit-picking. Somehow it is. However, while adding NetBSD, I had to analyze this BFD part and understand what the reason is, why this it is different. At the end, it turned out there was no reason. It was just different, actually a copy and paste of a patch from a community contribution.

That is why consistency I tried to restore consistency. Although it is harder to read, it makes more sense because in the rest of the ./configure script, it is used differently.


-- 
To view, visit https://gerrit.asterisk.org/8492
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a6f48127b7af3a48168c917e888be1f70625027
Gerrit-Change-Number: 8492
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Comment-Date: Fri, 09 Mar 2018 09:19:20 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180309/e8c18420/attachment.html>


More information about the asterisk-code-review mailing list