[Asterisk-code-review] BuildSystem: In NetBSD, the Python Programming Language is p... (asterisk[master])

Alexander Traud asteriskteam at digium.com
Thu Mar 8 03:55:22 CST 2018


Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/8424 )

Change subject: BuildSystem: In NetBSD, the Python Programming Language is python-2.7.
......................................................................


Patch Set 2:

In Asterisk, are
* make ari-stubs
* make doc/full-en_US.xml (accessed via: make full)
and in PJSIP, the pjsua Python bindings, compatible with Python 3.x?

If not, the previous check was wrong because the platforms might go for Python 3.x as default any time soon. Then, the current ‘python’ check should be replaced by a fallback statement like ‘python2.6’ (for CentOS 6). Furthermore, ./contrib/scripts/install_prereq should be changed, for example in Debian/Ubuntu it should go for ‘python2.7-dev’.

Finally, I found eight scripts which go for ‘#!/usr/bin/env python’ and ‘#!/usr/bin/python’. The scripts ast_coredumper and ast_loggrabber call a ‘python’ as well.

Until all this is investigated, documented and changed, this change here should pass because Python 2.7 works for sure.


-- 
To view, visit https://gerrit.asterisk.org/8424
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If90ddf9c396c32e7402a894f42dce215c30049d1
Gerrit-Change-Number: 8424
Gerrit-PatchSet: 2
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Thu, 08 Mar 2018 09:55:22 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180308/6d9fe4c4/attachment.html>


More information about the asterisk-code-review mailing list