[Asterisk-code-review] Remove dynamic-modules test. (testsuite[newmaster])
Kevin Harwell
asteriskteam at digium.com
Wed Mar 7 17:23:03 CST 2018
Kevin Harwell has uploaded this change for review. ( https://gerrit.asterisk.org/8468
Change subject: Remove dynamic-modules test.
......................................................................
Remove dynamic-modules test.
This test has been disabled since 2012. Due to reference counting
between modules (especially in master) this test is unworkable. The
ability to test unloads is better accomplished by enabling REF_DEBUG on
the entire testsuite and verifying that no leaks occur.
ASTERISK-19567 #close
Change-Id: I0c2ca9179cab3123477f7f75147596830efcdfd5
(cherry picked from commit d173472ac64f8a0850aac8d62dd5600f8a3b0fea)
---
D tests/dynamic-modules/configs/ast1/modules.conf
D tests/dynamic-modules/run-test
D tests/dynamic-modules/test-config.yaml
M tests/tests.yaml
4 files changed, 0 insertions(+), 184 deletions(-)
git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/68/8468/1
diff --git a/tests/dynamic-modules/configs/ast1/modules.conf b/tests/dynamic-modules/configs/ast1/modules.conf
deleted file mode 100644
index e71d535..0000000
--- a/tests/dynamic-modules/configs/ast1/modules.conf
+++ /dev/null
@@ -1,2 +0,0 @@
-[modules]
-autoload=no
diff --git a/tests/dynamic-modules/run-test b/tests/dynamic-modules/run-test
deleted file mode 100755
index 59cb023..0000000
--- a/tests/dynamic-modules/run-test
+++ /dev/null
@@ -1,169 +0,0 @@
-#!/usr/bin/env python
-'''
-Copyright (C) 2010, Digium, Inc.
-Paul Belanger <pabelanger at digium.com>
-
-This program is free software, distributed under the terms of
-the GNU General Public License Version 2.
-'''
-
-import sys
-import os
-import logging
-
-from twisted.internet import reactor, defer
-
-sys.path.append("lib/python")
-from asterisk.asterisk import Asterisk
-from asterisk.test_case import TestCase
-
-logger = logging.getLogger(__name__)
-
-class moduleLoadUnloadTest(TestCase):
- def __init__(self):
- TestCase.__init__(self)
- self.create_asterisk()
-
- def check_file(self, module):
- module[1] = (os.path.isfile("%s%s/%s" % (self.ast[0].base,
- self.ast[0].directories["astmoddir"], module[0])))
- return module[1]
-
- def pre_load_next(self):
- self.__preload_test_counter += 1
- if (self.__preload_test_counter < len(self.preload_res)):
- self.pre_load_module(self.preload_res[self.__preload_test_counter])
- else:
- self.load_next()
-
- def pre_load_module(self, module):
- def __module_callback(reason):
- text = "Loaded " + self.__module[0]
- if reason.output.count(text) > 0:
- self.__module[2] = True
- logger.debug("Pre-load %s: %r" % (self.__module[0], self.__module[2]))
- self.pre_load_next()
- return reason
-
- if not self.check_file(module):
- logger.info(module[0] + " does not exist! Skipping this test.")
- self.pre_load_next()
- return
-
- df = self.ast[0].cli_exec("module load " + module[0])
- df.addCallback(__module_callback)
- self.__module = module
-
- def load_next(self):
- self.__load_test_counter += 1
- if (self.__load_test_counter < len(self.res)):
- self.load_module(self.res[self.__load_test_counter])
- else:
- self.unload_next()
-
- def load_module(self, module):
- def __module_callback(reason):
- text = "Loaded " + self.__module[0]
- if reason.output.count(text) > 0:
- self.__module[2] = True
- logger.debug("Load %s: %r" % (self.__module[0], self.__module[2]))
- self.load_next()
- return reason
-
- if not self.check_file(module):
- logger.info(module[0] + " does not exist! Skipping test.")
- self.load_next()
- return
-
- df = self.ast[0].cli_exec("module load " + module[0])
- df.addCallback(__module_callback)
- self.__module = module
-
- def unload_next(self):
- self.__unload_test_counter += 1
- if (self.__unload_test_counter < len(self.unloads)):
- self.unload_module(self.unloads[self.__unload_test_counter])
- else:
- if not self.__checking_results:
- self.__checking_results = True
- self.check_results()
-
- def unload_module(self, module):
- def __module_callback(reason):
- text = "Unloaded " + self.__module[0]
- if reason.output.count(text) > 0:
- self.__module[3] = True
- logger.debug("Load %s: %r" % (self.__module[0], self.__module[3]))
- self.unload_next()
- return reason
-
- if not self.check_file(module):
- logger.info(module[0] + " does not exist! Skipping test.")
- self.unload_next()
- return
-
- # Don't attempt an unload if we didn't load it
- if not module[2]:
- self.unload_next()
- return
-
- df = self.ast[0].cli_exec("module unload " + module[0])
- df.addCallback(__module_callback)
- self.__module = module
-
- def check_results(self):
- logger.info("Checking Results")
- for module in self.unloads:
- if not self.check_file(module):
- logger.info(module[0] + " does not exist! Skipping test.")
- else:
- self.check_failures(module);
- self.stop_reactor()
-
- def check_failures(self, module):
- if not module[2]:
- logger.error("ERROR: Loading " + module[0])
- self.passed = False
-
- if not module[3]:
- logger.error("ERROR: Unloading " + module[0])
- self.passed = False
-
- def run(self):
- TestCase.run(self)
- self.passed = True
- self.preload_res = []
- self.res = []
- self.unloads = []
-
- # TODO: Do not hardcode, read from source code.
- preload_resources = ["res_calendar", "res_curl", "res_fax", "res_odbc"]
- self.preload_res = [ [module + ".so", False, False, False] for module in preload_resources ]
-
- # TODO: Do not hardcode, read from source code.
- # TODO: Fixed res_http_post crash
- resources = ["res_adsi", "res_ael_share", "res_agi", "res_ais", "res_calendar_caldav", "res_calendar_exchange", "res_calendar_icalendar", "res_clialiases", "res_clioriginate", "res_config_curl", "res_config_ldap", "res_config_odbc", "res_config_pgsql", "res_config_sqlite", "res_convert", "res_crypto", "res_fax_spandsp", "res_jabber", "res_limit", "res_monitor", "res_musiconhold", "res_mutestream", "res_phoneprov", "res_pktccops", "res_realtime", "res_rtp_asterisk", "res_rtp_multicast", "res_security_log", "res_smdi", "res_snmp", "res_speech", "res_timing_dahdi", "res_timing_kqueue", "res_timing_pthread", "res_timing_timerfd"]
- self.res = [ [module + ".so", False, False, False] for module in resources ]
- self.unloads.extend(self.preload_res)
- self.unloads.extend(self.res)
-
- self.__preload_test_counter = -1
- self.__load_test_counter = -1
- self.__unload_test_counter = -1
- self.__checking_results = False
- self.pre_load_next()
-
-
-def main():
- test = moduleLoadUnloadTest()
- test.start_asterisk()
- reactor.run()
- test.stop_asterisk()
- if test.passed:
- return 0
- return 1
-
-if __name__ == "__main__":
- sys.exit(main() or 0)
-
-# vim:sw=4:ts=4:expandtab:textwidth=79
diff --git a/tests/dynamic-modules/test-config.yaml b/tests/dynamic-modules/test-config.yaml
deleted file mode 100644
index 8abea4b..0000000
--- a/tests/dynamic-modules/test-config.yaml
+++ /dev/null
@@ -1,12 +0,0 @@
-testinfo:
- skip: 'See ASTERISK-19567'
- summary: 'Test dynamicly loading and unloading modules'
- description: |
- 'This test provides a basic sanity check on Asterisk
- modules.'
-
-properties:
- minversion: '1.8.0.0'
- dependencies:
- - python : 'twisted'
- - python : 'starpy'
diff --git a/tests/tests.yaml b/tests/tests.yaml
index 9d7ef0f..fc5321a 100644
--- a/tests/tests.yaml
+++ b/tests/tests.yaml
@@ -2,7 +2,6 @@
tests:
- test: 'example'
- dir: 'custom'
- - test: 'dynamic-modules'
- dir: 'manager'
- dir: 'cdr'
- dir: 'channels'
--
To view, visit https://gerrit.asterisk.org/8468
To unsubscribe, visit https://gerrit.asterisk.org/settings
Gerrit-Project: testsuite
Gerrit-Branch: newmaster
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0c2ca9179cab3123477f7f75147596830efcdfd5
Gerrit-Change-Number: 8468
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180307/239c924f/attachment-0001.html>
More information about the asterisk-code-review
mailing list