[Asterisk-code-review] app dial: Enable early-media video (asterisk[13])

[Florian Floimair]

Florian Floimair has posted comments on this change. ( https://gerrit.asterisk.org/8398 )

Change subject: app_dial: Enable early-media video
......................................................................


Patch Set 2:

> While this is a neat patch, technically it's a behavioral change
 > and a new feature for the branch.  The master patch can go through,
 > but in order to cherry pick this to 13 or 15, a testsuite patch
 > will need to be submitted.

Agreed, it's a behavioral change, that's why I have asked whether this should be a configurable/parameterized option. That way the default behavior can remain the same as before and the feature could still be used in 13 & 15 branches as well.
My idea was to use a new parameter for the Dial application that selectively enables early-media video for both ways (caller/callee) separately and is disabled by default if no parameter is given.

Would this be a viable option or would you still require to have the testsuite expanded?

Please let me know how to proceed.


-- 
To view, visit https://gerrit.asterisk.org/8398
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I9842e1dc2f6e1c2c49dc33fe615255007d2f821e
Gerrit-Change-Number: 8398
Gerrit-PatchSet: 2
Gerrit-Owner: Florian Floimair <f.floimair at commend.com>
Gerrit-Reviewer: Florian Floimair <f.floimair at commend.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 07 Mar 2018 11:38:37 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180307/e2f12670/attachment.html>