[Asterisk-code-review] Add the ability to read the media file type from HTTP header... (asterisk[15])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/8209 )

Change subject: Add the ability to read the media file type from HTTP header for playback
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.asterisk.org/#/c/8209/4/main/media_cache.c
File main/media_cache.c:

https://gerrit.asterisk.org/#/c/8209/4/main/media_cache.c@164
PS4, Line 164: 					/* Not updating the original ext here to keep the key for media-cache same */
             : 					snprintf(temp_ext, strlen(temp_ext), ".%s", tmp);
> temp_ext is defined as PATH_MAX. I think it is safe to assume that an exten
You are passing strlen(temp_ext) to snprintf() not sizeof(temp_ext).

Also I don't understand the limitation mentioned by the comment.  The file extension in tmp could be longer than the original file extension.



-- 
To view, visit https://gerrit.asterisk.org/8209
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I1b14692a49b2c1ac67688f58757184122e92ba89
Gerrit-Change-Number: 8209
Gerrit-PatchSet: 4
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Gaurav Khurana <gkhurana at godaddy.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Matt Jordan <mjordan at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 06 Mar 2018 16:39:46 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180306/b9c3b0a2/attachment-0001.html>