[Asterisk-code-review] res pjsip session: properly handle SDP from a forked call wi... (asterisk[15])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/8305 )

Change subject: res_pjsip_session: properly handle SDP from a forked call with early media
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/8305/3/res/res_pjsip_session.c
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/#/c/8305/3/res/res_pjsip_session.c@890
PS3, Line 890: 			    return -1;
This should have a warning as well, or else it'll be confusing to understand what is going on.


https://gerrit.asterisk.org/#/c/8305/3/res/res_pjsip_session.c@893
PS3, Line 893: 			ast_sip_session_media_state_free(session->pending_media_state);
This can never be non-NULL so you don't have to free it.



-- 
To view, visit https://gerrit.asterisk.org/8305
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: If0d5150ffe6f38d8a854831fef37942258d4629c
Gerrit-Change-Number: 8305
Gerrit-PatchSet: 3
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: lvl <digium at lvlconsultancy.nl>
Gerrit-Comment-Date: Tue, 06 Mar 2018 15:16:49 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180306/3fc26c0f/attachment-0001.html>