[Asterisk-code-review] res rtp asterisk: Add support for sending NACK requests. (asterisk[master])

[Benjamin Keith Ford]

Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/9225 )

Change subject: res_rtp_asterisk: Add support for sending NACK requests.
......................................................................


Patch Set 4:

(2 comments)

Everything else is updated, but curious on your thoughts about error handling with the generation of the RTCP packet before pushing up again.

https://gerrit.asterisk.org/#/c/9225/4/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/#/c/9225/4/res/res_rtp_asterisk.c@4402
PS4, Line 4402: 	if (res == 0 || res == 1) {
> This is probably silly, but unless we're actually using both failure values
So the issue here is that there are 2 different things that can happen that would cause these functions to fail. If 1 is returned as the error code, there was an allocation error (rtcp_report is NULL). If 0 is returned, then something else went wrong and RTCP is halted for the session. res < 0 should never happen, so the only other option is res > 1, which would probably be fine. I'm happy to change it to that if you think that's the right approach here. Thoughts?


https://gerrit.asterisk.org/#/c/9225/4/res/res_rtp_asterisk.c@4419
PS4, Line 4419: 		ast_rtp_instance_get_remote_address(instance, &remote_address);
> Why do we have to update remote_address here?
This was done when ast_rtcp_write_report was one function, it sent it out in there too instead of allowing for the structuring of the report and then deciding what to do. If rtp->bundled exists, this is the primary transport and it should be used instead of what we originally intended to use.



-- 
To view, visit https://gerrit.asterisk.org/9225
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Idab644b08a1593659c92cda64132ccc203fe991d
Gerrit-Change-Number: 9225
Gerrit-PatchSet: 4
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Comment-Date: Thu, 28 Jun 2018 15:50:30 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180628/8cb98861/attachment.html>