[Asterisk-code-review] Fixed locking issue in stasis app bridge moh channel (asterisk[15])

Richard Mudgett asteriskteam at digium.com
Tue Jun 26 19:28:30 CDT 2018


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/9297 )

Change subject: Fixed locking issue in stasis_app_bridge_moh_channel
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/9297/1/res/res_stasis.c
File res/res_stasis.c:

https://gerrit.asterisk.org/#/c/9297/1/res/res_stasis.c@588
PS1, Line 588: 	if (ast_string_field_init(new_wrapper, 32)) {
The initial size should be increased as we are likely to always need more space.

s/32/AST_UUID_STR_LEN + AST_CHANNEL_NAME/



-- 
To view, visit https://gerrit.asterisk.org/9297
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibff479e167b3320c68aaabfada7e1d0ef7bd548c
Gerrit-Change-Number: 9297
Gerrit-PatchSet: 1
Gerrit-Owner: Moritz Fain <moritz at fain.io>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 27 Jun 2018 00:28:30 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180626/f0d9109d/attachment.html>


More information about the asterisk-code-review mailing list