[Asterisk-code-review] matcher.py: Always check final conditions (testsuite[15])

Kevin Harwell asteriskteam at digium.com
Tue Jun 26 17:32:22 CDT 2018


Hello Jenkins2, George Joseph, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/9280

to look at the new patch set (#3).

Change subject: matcher.py: Always check final conditions
......................................................................

matcher.py: Always check final conditions

The matcher functionality was checking the final conditions only if the test
was marked as passed. Since the initial default value for the test_case
variable is 'None' this could cause the test to fail, but without error messages
output.

This patch makes it so the final condtions in matcher are always checked when
the test ends. Also if all final conditions pass then the test object is set
to passing (passed=true). Lastly the error message output was updated to make
it a little more readable.

Change-Id: Ibdd3041e8fb023b9396d80ec766ade934e50bcaa
---
M lib/python/asterisk/matcher.py
M lib/python/asterisk/self_test/test2_matcher.py
2 files changed, 17 insertions(+), 22 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/80/9280/3
-- 
To view, visit https://gerrit.asterisk.org/9280
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 15
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibdd3041e8fb023b9396d80ec766ade934e50bcaa
Gerrit-Change-Number: 9280
Gerrit-PatchSet: 3
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180626/91dfafc1/attachment-0001.html>


More information about the asterisk-code-review mailing list