[Asterisk-code-review] matcher.py: Always check final conditions (testsuite[13])

Richard Mudgett asteriskteam at digium.com
Tue Jun 26 14:53:34 CDT 2018


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/9278 )

Change subject: matcher.py: Always check final conditions
......................................................................


Patch Set 2:

(3 comments)

https://gerrit.asterisk.org/#/c/9278/2//COMMIT_MSG
Commit Message:

https://gerrit.asterisk.org/#/c/9278/2//COMMIT_MSG@10
PS2, Line 10: was marked as passed. Since the initial default value for that the test_case
s/that//


https://gerrit.asterisk.org/#/c/9278/2//COMMIT_MSG@11
PS2, Line 11: variable is 'None' this could cause the test to fail, but not error messages
s/not/without/


https://gerrit.asterisk.org/#/c/9278/2//COMMIT_MSG@12
PS2, Line 12: were output.
s/were//



-- 
To view, visit https://gerrit.asterisk.org/9278
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibdd3041e8fb023b9396d80ec766ade934e50bcaa
Gerrit-Change-Number: 9278
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 26 Jun 2018 19:53:34 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180626/ca4fd126/attachment.html>


More information about the asterisk-code-review mailing list