[Asterisk-code-review] chan ooh323: IPTOS MINCOST is not defined on Solaris. (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/9288 )

Change subject: chan_ooh323: IPTOS_MINCOST is not defined on Solaris.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/9288/1/addons/chan_ooh323.c
File addons/chan_ooh323.c:

https://gerrit.asterisk.org/#/c/9288/1/addons/chan_ooh323.c@3051
PS1, Line 3051: 				gTOS = 0x02;
How about creating a define for the 0x02? IPTOS_DEFAULT_MINCOST or something.  That way we know what this "magic value" is.



-- 
To view, visit https://gerrit.asterisk.org/9288
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Idc9153ece769944765b66122efb11728d8d8ebde
Gerrit-Change-Number: 9288
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Tue, 26 Jun 2018 13:09:37 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180626/dba330f0/attachment-0001.html>