[Asterisk-code-review] res rtp asterisk: Add support for sending NACK requests. (asterisk[15])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/9224 )

Change subject: res_rtp_asterisk: Add support for sending NACK requests.
......................................................................


Patch Set 3: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/9224/3/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/#/c/9224/3/res/res_rtp_asterisk.c@4119
PS3, Line 4119: 	rtcp_report->type = sr ? RTCP_PT_SR : RTCP_PT_RR;
should be *sr


https://gerrit.asterisk.org/#/c/9224/3/res/res_rtp_asterisk.c@4120
PS3, Line 4120: 	if (sr) {
should be *sr


https://gerrit.asterisk.org/#/c/9224/3/res/res_rtp_asterisk.c@4149
PS3, Line 4149: 	if (sr) {
should be *sr


https://gerrit.asterisk.org/#/c/9224/3/res/res_rtp_asterisk.c@4168
PS3, Line 4168: 				| ((sr ? RTCP_PT_SR : RTCP_PT_RR) << 16) | ((len/4)-1)));
should be *sr



-- 
To view, visit https://gerrit.asterisk.org/9224
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Idab644b08a1593659c92cda64132ccc203fe991d
Gerrit-Change-Number: 9224
Gerrit-PatchSet: 3
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Mon, 25 Jun 2018 16:22:14 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180625/383ebe52/attachment-0001.html>