[Asterisk-code-review] uuid: Enable UUID in Solaris 11. (asterisk[13])

George Joseph asteriskteam at digium.com
Fri Jun 22 09:18:52 CDT 2018


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/9268 )

Change subject: uuid: Enable UUID in Solaris 11.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/9268/1/main/uuid.c
File main/uuid.c:

https://gerrit.asterisk.org/#/c/9268/1/main/uuid.c@139
PS1, Line 139: 	uuid_unparse(uuid->uu, buf);
It's possible that external modules might be relying on a lower case representation even though it's not documented as guaranteeing lower case.  Maybe just add an ast_str_to_lower().



-- 
To view, visit https://gerrit.asterisk.org/9268
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b8362824efbfb2a16981e46e85f7c8322908c49
Gerrit-Change-Number: 9268
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Comment-Date: Fri, 22 Jun 2018 14:18:52 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180622/9f5d6902/attachment-0001.html>


More information about the asterisk-code-review mailing list