[Asterisk-code-review] res rtp asterisk: Add support for sending NACK requests. (asterisk[15])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/9224 )

Change subject: res_rtp_asterisk: Add support for sending NACK requests.
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.asterisk.org/#/c/9224/2/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/#/c/9224/2/res/res_rtp_asterisk.c@6749
PS2, Line 6749: 				/* Define our starting point, or recover from a large gap of lost packets */
> My idea to work around this is to pull everything from the buffer, queue it
+1


https://gerrit.asterisk.org/#/c/9224/2/res/res_rtp_asterisk.c@6777
PS2, Line 6777: 					ast_data_buffer_put(rtp->recv_buffer, seqno, f);
> For this one I have a couple different ideas. The first idea is queuing a &
I like the second idea too, it gives it a fighting chance.



-- 
To view, visit https://gerrit.asterisk.org/9224
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Idab644b08a1593659c92cda64132ccc203fe991d
Gerrit-Change-Number: 9224
Gerrit-PatchSet: 2
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Thu, 21 Jun 2018 20:21:08 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180621/5fef520a/attachment-0001.html>