[Asterisk-code-review] Begin work on python3 compatability. (testsuite[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/8854 )

Change subject: Begin work on python3 compatability.
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.asterisk.org/#/c/8854/6/runtests.py
File runtests.py:

https://gerrit.asterisk.org/#/c/8854/6/runtests.py@152
PS6, Line 152:                     l = p.stdout.readline().decode('utf-8', 'replace').strip()
> tests/apps/confbridge/confbridge_marked
Thanks for letting me know, I found the parts that deal with python3 string encoding to be especially difficult.

I was not able to reproduce this error with that specific test so I replaced one of the `run-test` scripts with something that just printed \ufffd, I was able to get the error but it was from self.stdout_print(l) just below.  Switching this line to `.decode('ascii', 'replace')` seems to fix the error, please let me know if this works for you as well.



-- 
To view, visit https://gerrit.asterisk.org/8854
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If76c2d3e11e4ab4552d0df7841287c8bb2de7918
Gerrit-Change-Number: 8854
Gerrit-PatchSet: 6
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Thu, 21 Jun 2018 00:15:46 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180620/629448db/attachment.html>