[Asterisk-code-review] tests/channels/SIP/rfc2833 dtmf detect: Requires rawsocket. (testsuite[13])

Corey Farrell asteriskteam at digium.com
Wed Jun 20 18:26:35 CDT 2018


Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/9233 )

Change subject: tests/channels/SIP/rfc2833_dtmf_detect: Requires rawsocket.
......................................................................


Patch Set 1:

> I received the same error, but after running as root it passed. It
 > doesn't seem like the dependency is required. Adding it just makes
 > it skip the test if the dependency is not met. Which it won't?

rawsocket typically requires root, it's not really a dependency that can be missing.  The 'dependency' actually just verifies that `socket.socket(socket.AF_PACKET, socket.SOCK_RAW)` passes.  See lib/python/asterisk/test_config.py Dependency.depend_rawsocket for the test code.


-- 
To view, visit https://gerrit.asterisk.org/9233
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d4307d8e54f36e9c59dfc5096accea321cff7d6
Gerrit-Change-Number: 9233
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 20 Jun 2018 23:26:35 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180620/5b48ee57/attachment.html>


More information about the asterisk-code-review mailing list