[Asterisk-code-review] Fix some doxygen and curly placement. (asterisk[13])

Kevin Harwell asteriskteam at digium.com
Wed Jun 20 17:15:36 CDT 2018


Kevin Harwell has submitted this change and it was merged. ( https://gerrit.asterisk.org/9203 )

Change subject: Fix some doxygen and curly placement.
......................................................................

Fix some doxygen and curly placement.

Change-Id: I9a784a7c804120a8fa826c2a4cb9957e4b0b2fc8
---
M include/asterisk/utils.h
M main/pbx_functions.c
2 files changed, 11 insertions(+), 9 deletions(-)

Approvals:
  George Joseph: Looks good to me, but someone else must approve
  Kevin Harwell: Looks good to me, approved; Approved for Submit



diff --git a/include/asterisk/utils.h b/include/asterisk/utils.h
index f8f761d..e8cff59 100644
--- a/include/asterisk/utils.h
+++ b/include/asterisk/utils.h
@@ -1100,7 +1100,7 @@
  */
 char *ast_crypt(const char *key, const char *salt);
 
-/*
+/*!
  * \brief Asterisk wrapper around crypt(3) for encrypting passwords.
  *
  * This function will generate a random salt and encrypt the given password.
@@ -1113,7 +1113,7 @@
  */
 char *ast_crypt_encrypt(const char *key);
 
-/*
+/*!
  * \brief Asterisk wrapper around crypt(3) for validating passwords.
  *
  * \param key User's password to validate.
@@ -1123,7 +1123,7 @@
  */
 int ast_crypt_validate(const char *key, const char *expected);
 
-/*
+/*!
  * \brief Test that a file exists and is readable by the effective user.
  * \since 13.7.0
  *
@@ -1133,7 +1133,7 @@
  */
 int ast_file_is_readable(const char *filename);
 
-/*
+/*!
  * \brief Compare 2 major.minor.patch.extra version strings.
  * \since 13.7.0
  *
@@ -1146,7 +1146,7 @@
  */
 int ast_compare_versions(const char *version1, const char *version2);
 
-/*
+/*!
  * \brief Test that an OS supports IPv6 Networking.
  * \since 13.14.0
  *
@@ -1160,7 +1160,7 @@
 	AST_FD_FLAG_CLEAR,
 };
 
-/*
+/*!
  * \brief Set flags on the given file descriptor
  * \since 13.19
  *
@@ -1176,7 +1176,7 @@
 #define ast_fd_set_flags(fd, flags) \
 	__ast_fd_set_flags((fd), (flags), AST_FD_FLAG_SET, __FILE__, __LINE__, __PRETTY_FUNCTION__)
 
-/*
+/*!
  * \brief Clear flags on the given file descriptor
  * \since 13.19
  *
diff --git a/main/pbx_functions.c b/main/pbx_functions.c
index 558be46..b127693 100644
--- a/main/pbx_functions.c
+++ b/main/pbx_functions.c
@@ -302,7 +302,8 @@
  * \return True (non-zero) if reads escalate privileges.
  * \return False (zero) if reads just read.
  */
-static int read_escalates(const struct ast_custom_function *acf) {
+static int read_escalates(const struct ast_custom_function *acf)
+{
 	return acf->read_escalates;
 }
 
@@ -313,7 +314,8 @@
  * \return True (non-zero) if writes escalate privileges.
  * \return False (zero) if writes just write.
  */
-static int write_escalates(const struct ast_custom_function *acf) {
+static int write_escalates(const struct ast_custom_function *acf)
+{
 	return acf->write_escalates;
 }
 

-- 
To view, visit https://gerrit.asterisk.org/9203
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: merged
Gerrit-Change-Id: I9a784a7c804120a8fa826c2a4cb9957e4b0b2fc8
Gerrit-Change-Number: 9203
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180620/0bc2ca6b/attachment-0001.html>


More information about the asterisk-code-review mailing list