[Asterisk-code-review] tcptls.h: Remove redundant SSL CTX typedef. (asterisk[15])

Alexander Traud asteriskteam at digium.com
Wed Jun 20 06:04:50 CDT 2018


Alexander Traud has posted comments on this change. ( https://gerrit.asterisk.org/9195 )

Change subject: tcptls.h: Remove redundant SSL_CTX typedef.
......................................................................


Patch Set 1: Code-Review-1

The typedef itself is not redundant because the local header uses it but does not know about it, yet. The build system makes it redundant. If you want to avoid the typedef, we have to look into how to solve that.

It would be cool if the Asterisk/Digium folks could start using Git, Jira, and Gerrit. This issue was introduced by me recently. In Git, you look up which change to blame (works even in the GitHub mirror). Then, you create an issue report on Jira and link that to the original one. Then in Gerrit, you invite the one who introduced that change. That way, the original author can is notified and can double-check. If the fix is correct, the original author is able to learn and improve. If the fix is incorrect/incomplete, the original author is able to block it.


-- 
To view, visit https://gerrit.asterisk.org/9195
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: I5a7d4565990c985822d61ce75bde0b45f9870540
Gerrit-Change-Number: 9195
Gerrit-PatchSet: 1
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Alexander Traud <pabstraud at compuserve.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Wed, 20 Jun 2018 11:04:50 +0000
Gerrit-HasComments: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180620/8de4fbbe/attachment.html>


More information about the asterisk-code-review mailing list