[Asterisk-code-review] app mp3: remove 10 seconds of silence after mp3 playback (asterisk[master])

Sam Wierema asteriskteam at digium.com
Fri Jun 15 03:17:45 CDT 2018


Hello Richard Mudgett, Jenkins2, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/9179

to look at the new patch set (#2).

Change subject: app_mp3: remove 10 seconds of silence after mp3 playback
......................................................................

app_mp3: remove 10 seconds of silence after mp3 playback

This patch changes the way asterisk polls output from mpg123, instead
of waiting for 10 seconds(when playing an http url) it now uses a
timeout of one second and iterates 10 times using this same timeout.

The main difference is that for every timeout asterisk receives it now
checks if mpg123 is still running before poll again.

Fixes ASTERISK-27752.

Change-Id: Ib7df8462e3e380cb328011890ad9270d9e9b4620
---
M apps/app_mp3.c
1 file changed, 25 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/79/9179/2
-- 
To view, visit https://gerrit.asterisk.org/9179
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib7df8462e3e380cb328011890ad9270d9e9b4620
Gerrit-Change-Number: 9179
Gerrit-PatchSet: 2
Gerrit-Owner: Sam Wierema <sam at messagebird.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180615/14f9edfe/attachment.html>


More information about the asterisk-code-review mailing list