[Asterisk-code-review] chan iax2: better handling for timeout and EINTR (asterisk[15])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/9087 )

Change subject: chan_iax2: better handling for timeout and EINTR
......................................................................


Patch Set 2: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/9087/2/channels/chan_iax2.c
File channels/chan_iax2.c:

https://gerrit.asterisk.org/#/c/9087/2/channels/chan_iax2.c@12567
PS2, Line 12567: 		if (res < 0  && res != -EINTR)
ast_io_wait() returns -1 on error.  If you want to know which one you should look at errno not res.


https://gerrit.asterisk.org/#/c/9087/2/channels/chan_iax2.c@12568
PS2, Line 12568: 		{
Guidelines: Curly placement


https://gerrit.asterisk.org/#/c/9087/2/channels/chan_iax2.c@12569
PS2, Line 12569: 			ast_log(LOG_ERROR, "Thread exit =%s \n", strerror(errno));
This message is not very descriptive and will confuse people.

ast_log(LOG_ERROR, "IAX2 network thread unexpected exit: %s\n", strerror(errno));



-- 
To view, visit https://gerrit.asterisk.org/9087
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4c32562f69335869adc1783608e940c3535fbfb
Gerrit-Change-Number: 9087
Gerrit-PatchSet: 2
Gerrit-Owner: Kirsty Tyerman <kirsty.tyerman at boeing.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kirsty Tyerman <kirsty.tyerman at boeing.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 12 Jun 2018 22:21:30 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180612/d61a7cd7/attachment-0001.html>