[Asterisk-code-review] chan iax2: better handling for timeout and EINTR (asterisk[15])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/9087 )

Change subject: chan_iax2: better handling for timeout and EINTR
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/9087/1/channels/chan_iax2.c
File channels/chan_iax2.c:

https://gerrit.asterisk.org/#/c/9087/1/channels/chan_iax2.c@12554
PS1, Line 12554:     int res;
This needs to follow the formatting of the existing code.


https://gerrit.asterisk.org/#/c/9087/1/channels/chan_iax2.c@12569
PS1, Line 12569: 		    ast_log(LOG_ERROR, "Thread exit =%s \n", strerror(errno));
Would this occur under normal circumstances at all and result in confusion by the user? Should it be a debug message instead?



-- 
To view, visit https://gerrit.asterisk.org/9087
To unsubscribe, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib4c32562f69335869adc1783608e940c3535fbfb
Gerrit-Change-Number: 9087
Gerrit-PatchSet: 1
Gerrit-Owner: Kirsty Tyerman <kirsty.tyerman at boeing.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Thu, 07 Jun 2018 12:47:18 +0000
Gerrit-HasComments: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180607/671ca293/attachment.html>