[Asterisk-code-review] fax/pjsip/t38 fast reject: Fix logs left in testsuite tree (testsuite[13])

Richard Mudgett asteriskteam at digium.com
Mon Jul 30 17:06:29 CDT 2018


Hello Jenkins2, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/9788

to look at the new patch set (#2).

Change subject: fax/pjsip/t38_fast_reject: Fix logs left in testsuite tree
......................................................................

fax/pjsip/t38_fast_reject: Fix logs left in testsuite tree

We don't need to pollute the testsuite tree with log files that are not
needed.

In run-test:
* Don't generate log files that are not needed.
* Fix to use a temp file out of the testsuite tree on the only SIPp log
file needed so it is not left in the testsuite tree.
* Fixed PEP8 errors

In A_PARTY.xml
* Removed extra optional recv 100 msgs.
* Fixed indention

In B_PARTY.xml
* Fix <CR><LF> line endings to <LF>.
* Fixed indention

In check_reinvite_rtt.py:
* Fixed type mismatch error when a slow 488 T.38 rejection is detected.
* Fixed PEP8 errors

Change-Id: Ic8e4d71f841627479c943c3b8a25e4776534258d
---
M tests/fax/pjsip/t38_fast_reject/check_reinvite_rtt.py
M tests/fax/pjsip/t38_fast_reject/run-test
M tests/fax/pjsip/t38_fast_reject/sipp/A_PARTY.xml
M tests/fax/pjsip/t38_fast_reject/sipp/B_PARTY.xml
M tests/fax/pjsip/t38_fast_reject/test-config.yaml
5 files changed, 236 insertions(+), 261 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/testsuite refs/changes/88/9788/2
-- 
To view, visit https://gerrit.asterisk.org/9788
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 13
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic8e4d71f841627479c943c3b8a25e4776534258d
Gerrit-Change-Number: 9788
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Jenkins2
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180730/62f519f0/attachment.html>


More information about the asterisk-code-review mailing list