[Asterisk-code-review] thirdparty/pjproject: fix deadlock in response retransmissions (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/9477 )

Change subject: thirdparty/pjproject: fix deadlock in response retransmissions
......................................................................


Patch Set 11:

> Uploaded patch set 11.

I changed the order of updating the inv->last_response.  There was no need to do it after calling pjsip_dlg_modify_response().  The only references to inv->last_response were to save the initial response, get the response to use for a new resposne, clear the stored tdata object on INVITE transaction termination, or check to see if it were NULL.

The tdata clone routine only handles cloning responses.  We'll see what Teluu does with that.  They might want to make it more generic even though the current users use it to clone for responses.


-- 
To view, visit https://gerrit.asterisk.org/9477
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic381004a3a212fe1d8eca0e707fe09dba4a6ab4e
Gerrit-Change-Number: 9477
Gerrit-PatchSet: 11
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Torrey Searle <tsearle at gmail.com>
Gerrit-Comment-Date: Mon, 30 Jul 2018 17:51:08 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180730/98055e0c/attachment.html>