[Asterisk-code-review] res pjsip pubsub: Treat "prune on boot" as a boolean. (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Fri Jul 27 10:41:19 CDT 2018


Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/9744 )

Change subject: res_pjsip_pubsub: Treat "prune_on_boot" as a boolean.
......................................................................


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/9744/1/res/res_pjsip_pubsub.c
File res/res_pjsip_pubsub.c:

https://gerrit.asterisk.org/#/c/9744/1/res/res_pjsip_pubsub.c@5606
PS1, Line 5606: 	ast_sorcery_object_field_register_custom(sorcery, "subscription_persistence", "prune_on_boot", "no",
              : 		persistence_prune_on_boot_str2int, persistence_prune_on_boot_int2str, NULL, 0, 0);
Should change this to a OPT_YESNO_T type instead.



-- 
To view, visit https://gerrit.asterisk.org/9744
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic8b9211b36babefe78f70def6828a135a6ae7ab6
Gerrit-Change-Number: 9744
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Fri, 27 Jul 2018 15:41:19 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180727/7e525762/attachment-0001.html>


More information about the asterisk-code-review mailing list