[Asterisk-code-review] loader: Process dependencies for built-in modules. (asterisk[16])

Corey Farrell asteriskteam at digium.com
Thu Jul 26 14:29:05 CDT 2018


Hello Jenkins2, George Joseph, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/9717

to look at the new patch set (#3).

Change subject: loader: Process dependencies for built-in modules.
......................................................................

loader: Process dependencies for built-in modules.

With the new module loader it was missed that built-in modules never
parsed dependencies from mod->info into vectors of mod.  This caused
manager to be initialized before acl (named_acl).  If manager.conf
used any named ACL's they would not be found and result in no ACL being
applied to the AMI user.

In addition to the manager ACL fix this adds "extconfig" to all builtin
modules which support realtime configuration.  This only matters if one
of the builtin modules is configured with 'preload', depending on
"extconfig" will cause config.c to automatically be initialize during
the preload stage.

Change-Id: I482ed6bca6c1064b05bb538d7861cd7a4f02d9fc
---
M main/cdr.c
M main/cel.c
M main/dnsmgr.c
M main/dsp.c
M main/enum.c
M main/features.c
M main/http.c
M main/indications.c
M main/loader.c
M main/logger.c
M main/manager.c
M main/named_acl.c
M main/plc.c
M main/sounds.c
M main/udptl.c
15 files changed, 32 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/17/9717/3
-- 
To view, visit https://gerrit.asterisk.org/9717
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I482ed6bca6c1064b05bb538d7861cd7a4f02d9fc
Gerrit-Change-Number: 9717
Gerrit-PatchSet: 3
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180726/bfd51d4b/attachment.html>


More information about the asterisk-code-review mailing list