[Asterisk-code-review] Build System: Create 'make configs' target. (asterisk[13])

George Joseph asteriskteam at digium.com
Thu Jul 26 08:23:18 CDT 2018


George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/9616 )

Change subject: Build System: Create 'make configs' target.
......................................................................


Patch Set 1:

> > My only concern with this is the naming. I could see people
 > > installing getting confused and accidentally using this instead
 > of
 > > samples (I've done it before personally until I remember that the
 > > target it samples for the sample configs).
 > 
 > I'm open to renaming it.  Maybe 'make install-configs'?  That way
 > using it wouldn't be accidental.

I like 'install-configs'.


-- 
To view, visit https://gerrit.asterisk.org/9616
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Idcd841df3c8d5bfe23d566bb9e2e448e9df4f8ab
Gerrit-Change-Number: 9616
Gerrit-PatchSet: 1
Gerrit-Owner: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Thu, 26 Jul 2018 13:23:18 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180726/fd8b0394/attachment-0001.html>


More information about the asterisk-code-review mailing list