[Asterisk-code-review] bridge: suppress initial connected line update on attended t... (asterisk[13])

Alexei Gradinari asteriskteam at digium.com
Wed Jul 25 16:56:38 CDT 2018


Hello Richard Mudgett, Jenkins2, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/9558

to look at the new patch set (#2).

Change subject: bridge: suppress initial connected line update on attended transfer
......................................................................

bridge: suppress initial connected line update on attended transfer

Alice calls Bob.
Alice does an attended transfer to Charlie.
The Caller ID is modified to some ID using either CALLERID function
or Dial options 'o([x])' on outgoing context before Dial Charlie's endpoint.
But the From: header contains "Alice" on INVITE to Charlie,
and not what is set before.

The apps Dial/Followme/Queue initially correctly set CONNECTED LINE
on outgoing channels as CALLERID of the originating channel.
But then the app reads pending CONNECTED LINE update on the originating
channel and sets CONNECTED LINE on outgoing channels with this data.

This patch suppress the connected line update on attended transfer
initial state "Calling Target" to avoid the pending connected line update.
And also suppress the connected line update on "DTMF Swap"
between the target and the transferee.

ASTERISK-27980 #close

Change-Id: I346652661949b6611c23e431ede0dbea1be3017a
---
M include/asterisk/bridge_internal.h
M main/bridge.c
M main/bridge_basic.c
3 files changed, 15 insertions(+), 14 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/58/9558/2
-- 
To view, visit https://gerrit.asterisk.org/9558
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I346652661949b6611c23e431ede0dbea1be3017a
Gerrit-Change-Number: 9558
Gerrit-PatchSet: 2
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180725/ac2fe7a5/attachment.html>


More information about the asterisk-code-review mailing list