[Asterisk-code-review] app dial: remove pending CONNECTED LINE updates before initi... (asterisk[13])

Alexei Gradinari asteriskteam at digium.com
Tue Jul 24 14:27:24 CDT 2018


Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/9558 )

Change subject: app_dial: remove pending CONNECTED LINE updates before initialize calls
......................................................................


Patch Set 1:

> You may simply need make sure that the ast_call() channel
 > technology specific function completes before returning for PJSIP
 > channels.  chan_pjsip.c:chan_pjsip_call() change ast_sip_push_task()
 > to ast_ast_sip_push_task_wait_serializer() to avoid the race
 > condition of the connected line information being updated before
 > the INVITE goes out.

This will only postpone the incorrect connected line update to propagate to called party.


-- 
To view, visit https://gerrit.asterisk.org/9558
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I346652661949b6611c23e431ede0dbea1be3017a
Gerrit-Change-Number: 9558
Gerrit-PatchSet: 1
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 24 Jul 2018 19:27:24 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180724/6667b6cb/attachment.html>


More information about the asterisk-code-review mailing list