[Asterisk-code-review] SRTP Tests: Adjust off-nominal tests with short lifetimes (testsuite[16.0])

Jenkins2 asteriskteam at digium.com
Tue Jul 24 07:55:14 CDT 2018


Jenkins2 has submitted this change and it was merged. ( https://gerrit.asterisk.org/9638 )

Change subject: SRTP Tests:  Adjust off-nominal tests with short lifetimes
......................................................................

SRTP Tests:  Adjust off-nominal tests with short lifetimes

A recent patch to Asterisk lowered the srtp lifetime limit from
1800000 to 1048576 so off-nominal tests that were expected to fail
were now passing.

This patch lowers the lifetime used in those tests below the new
lower limit.

Change-Id: I4e957ce1f27bc682fe3d7e90c1a2c9490d8ee912
---
M tests/channels/SIP/sip_srtp/srtp_sdp_offer_answer/sipp/inject_attrib_single_off_nominal.csv
M tests/channels/pjsip/secure_calling/srtp_negotiation/sipp/decline.csv
2 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Joshua Colp: Looks good to me, but someone else must approve
  Jenkins2: Looks good to me, approved; Approved for Submit



diff --git a/tests/channels/SIP/sip_srtp/srtp_sdp_offer_answer/sipp/inject_attrib_single_off_nominal.csv b/tests/channels/SIP/sip_srtp/srtp_sdp_offer_answer/sipp/inject_attrib_single_off_nominal.csv
index 2d1d523..24caaeb 100644
--- a/tests/channels/SIP/sip_srtp/srtp_sdp_offer_answer/sipp/inject_attrib_single_off_nominal.csv
+++ b/tests/channels/SIP/sip_srtp/srtp_sdp_offer_answer/sipp/inject_attrib_single_off_nominal.csv
@@ -11,8 +11,8 @@
 1 AES_CM_128_HMAC_SHA1_80 inline:Ar/jYxzGz1lLcR;
 1 AES_CM_128_HMAC_SHA1_80 Ar/jYxzGz1lLcROAnVi8IFGB2VJlynqKBhjaVvgb
 1 AES_CM_128_HMAC_SHA1_80 inlineAr/jYxzGz1lLcROAnVi8IFGB2VJlynqKBhjaVvgb
-1 AES_CM_128_HMAC_SHA1_80 inline:Ar/jYxzGz1lLcROAnVi8IFGB2VJlynqKBhjaVvgb|2^20;
-1 AES_CM_128_HMAC_SHA1_80 inline:Ar/jYxzGz1lLcROAnVi8IFGB2VJlynqKBhjaVvgb|1799999;
+1 AES_CM_128_HMAC_SHA1_80 inline:Ar/jYxzGz1lLcROAnVi8IFGB2VJlynqKBhjaVvgb|2^19
+1 AES_CM_128_HMAC_SHA1_80 inline:Ar/jYxzGz1lLcROAnVi8IFGB2VJlynqKBhjaVvgb|1048575
 1 AES_CM_128_HMAC_SHA1_80 inline:Ar/jYxzGz1lLcROAnVi8IFGB2VJlynqKBhjaVvgb|monkeys!;
 1 AES_CM_128_HMAC_SHA1_80 inline:Ar/jYxzGz1lLcROAnVi8IFGB2VJlynqKBhjaVvgb|2^32|2:4;
 1 AES_CM_128_HMAC_SHA1_80 inline:Ar/jYxzGz1lLcROAnVi8IFGB2VJlynqKBhjaVvgb||1:4;
diff --git a/tests/channels/pjsip/secure_calling/srtp_negotiation/sipp/decline.csv b/tests/channels/pjsip/secure_calling/srtp_negotiation/sipp/decline.csv
index 2d1d523..24caaeb 100644
--- a/tests/channels/pjsip/secure_calling/srtp_negotiation/sipp/decline.csv
+++ b/tests/channels/pjsip/secure_calling/srtp_negotiation/sipp/decline.csv
@@ -11,8 +11,8 @@
 1 AES_CM_128_HMAC_SHA1_80 inline:Ar/jYxzGz1lLcR;
 1 AES_CM_128_HMAC_SHA1_80 Ar/jYxzGz1lLcROAnVi8IFGB2VJlynqKBhjaVvgb
 1 AES_CM_128_HMAC_SHA1_80 inlineAr/jYxzGz1lLcROAnVi8IFGB2VJlynqKBhjaVvgb
-1 AES_CM_128_HMAC_SHA1_80 inline:Ar/jYxzGz1lLcROAnVi8IFGB2VJlynqKBhjaVvgb|2^20;
-1 AES_CM_128_HMAC_SHA1_80 inline:Ar/jYxzGz1lLcROAnVi8IFGB2VJlynqKBhjaVvgb|1799999;
+1 AES_CM_128_HMAC_SHA1_80 inline:Ar/jYxzGz1lLcROAnVi8IFGB2VJlynqKBhjaVvgb|2^19
+1 AES_CM_128_HMAC_SHA1_80 inline:Ar/jYxzGz1lLcROAnVi8IFGB2VJlynqKBhjaVvgb|1048575
 1 AES_CM_128_HMAC_SHA1_80 inline:Ar/jYxzGz1lLcROAnVi8IFGB2VJlynqKBhjaVvgb|monkeys!;
 1 AES_CM_128_HMAC_SHA1_80 inline:Ar/jYxzGz1lLcROAnVi8IFGB2VJlynqKBhjaVvgb|2^32|2:4;
 1 AES_CM_128_HMAC_SHA1_80 inline:Ar/jYxzGz1lLcROAnVi8IFGB2VJlynqKBhjaVvgb||1:4;

-- 
To view, visit https://gerrit.asterisk.org/9638
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 16.0
Gerrit-MessageType: merged
Gerrit-Change-Id: I4e957ce1f27bc682fe3d7e90c1a2c9490d8ee912
Gerrit-Change-Number: 9638
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180724/9e7dbea1/attachment-0001.html>


More information about the asterisk-code-review mailing list