[Asterisk-code-review] res rtp asterisk: Avoid merging command and regular T.140 te... (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Fri Jul 20 12:32:29 CDT 2018


Richard Mudgett has uploaded a new patch set (#6) to the change originally created by Emmanuel BUU. ( https://gerrit.asterisk.org/9510 )

Change subject: res_rtp_asterisk: Avoid merging command and regular T.140 text packets
......................................................................

res_rtp_asterisk: Avoid merging command and regular T.140 text packets

When realtime text packets are to be sent, the text is accumulated in a
buffer and sent regularly by a timer.  It can happen that commands such as
a backspace, CR, or LF get merged with regular text.  This breaks some
UAs.

The proposed change:
* We test if the current packet contains a command.  If so we send the
buffer immediately.
* We test if the buffer contained a command.  If so we send the buffer
immediately.
* We accumulate the text (or the command) in the buffer.

ASTERISK-27970

Change-Id: Ifbe993311410fa855cb8aa4a12084db75f413462
---
M res/res_rtp_asterisk.c
1 file changed, 22 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/10/9510/6
-- 
To view, visit https://gerrit.asterisk.org/9510
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifbe993311410fa855cb8aa4a12084db75f413462
Gerrit-Change-Number: 9510
Gerrit-PatchSet: 6
Gerrit-Owner: Emmanuel BUU <emmanuel.buu at ives.fr>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180720/aa52f61c/attachment-0001.html>


More information about the asterisk-code-review mailing list