[Asterisk-code-review] thirdparty/pjproject: Fix deadlock in response retransmissions (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/9477 )

Change subject: thirdparty/pjproject: Fix deadlock in response retransmissions
......................................................................


Patch Set 4: Code-Review-1

I don't think this is the right approach to fixing the reentrancy deadlock as I think it will cause deadlocks between the dialog and transaction locks.

I think there should be two tdata objects here instead of the same one in two places.  The transaction should keep a last sent message that it can simply resend unmodified and the invite should keep a last sent message that it can modify as conditions in the negotiation change.  Asterisk itself updates the invite's last sent tdata returned by pjsip_inv_answer() without locks to add headers, set the response code, and such when it prepares the updated response.


-- 
To view, visit https://gerrit.asterisk.org/9477
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic381004a3a212fe1d8eca0e707fe09dba4a6ab4e
Gerrit-Change-Number: 9477
Gerrit-PatchSet: 4
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 18 Jul 2018 20:02:00 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180718/d2064e38/attachment-0001.html>