[Asterisk-code-review] res rtp asterisk: avoid merging command and regular T140 tex... (asterisk[13])

Emmanuel BUU asteriskteam at digium.com
Fri Jul 20 04:00:32 CDT 2018


Hello Richard Mudgett, Jenkins2, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/9510

to look at the new patch set (#4).

Change subject: res_rtp_asterisk: avoid merging command and regular T140 text packets
......................................................................

res_rtp_asterisk: avoid merging command and regular T140 text packets

When realtime text packets are to be sent, the text is accumulated
in a buffer and sent regularilty by a timer. It can happend that
commands such as a backspace or CR or LF gets merged with regular
text. This breaks some of the UAs.

The proposed change:
* We test if the current packet contains a command. If so we send the
buffer immediatly
* We test if the buffer contained a command. If so we send the buffer
immediatly
* We accumulate the text (or the command) in the buffer
Change-Id: Ifbe993311410fa855cb8aa4a12084db75f413462
Reported by: Emmanuel BUU
Tested by: Emmanuel BUU
ASTERISK-27970
---
M res/res_rtp_asterisk.c
1 file changed, 17 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/10/9510/4
-- 
To view, visit https://gerrit.asterisk.org/9510
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ifbe993311410fa855cb8aa4a12084db75f413462
Gerrit-Change-Number: 9510
Gerrit-PatchSet: 4
Gerrit-Owner: Emmanuel BUU <emmanuel.buu at ives.fr>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180720/8aefeba6/attachment.html>


More information about the asterisk-code-review mailing list