[Asterisk-code-review] t38 fast reject: remove dependency on rtpdump (testsuite[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/9379 )

Change subject: t38_fast_reject: remove dependency on rtpdump
......................................................................


Patch Set 1: Code-Review-2

We had a bit of a discussion in asterisk-dev about allowing tests written in languages other than python. Historically this was allowed, but the consensus is now they should be strictly kept to python (if being submitted to the main code base) unless otherwise required (and explained why). However, if written in something other than python then there should be no external module dependencies that need to be installed for the test for a given language. This will greatly cut down on the number of potential dependencies required to execute the testsuite.

For instance, this test requires the Text::CSV module to be installed in order to execute/pass.

Unfortunately to move forward with this, this test will either need to be:

1. rewritten to just use python (the preferred option)
2. written to not be dependent on any external perl module

Sorry about all this as I know this test was already accepted for submission and this is just an update to fix another problem.


-- 
To view, visit https://gerrit.asterisk.org/9379
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia73ef502f72bd75522d4b6656f6070807dbef349
Gerrit-Change-Number: 9379
Gerrit-PatchSet: 1
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 18 Jul 2018 17:43:32 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180718/e27ed84d/attachment.html>