[Asterisk-code-review] SWP-8578 stasis: Improve message type (asterisk[15])

Joshua Colp asteriskteam at digium.com
Wed Jul 18 11:59:21 CDT 2018


Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/9511 )

Change subject: SWP-8578 stasis: Improve message type
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/9511/1/main/stasis.c
File main/stasis.c:

https://gerrit.asterisk.org/#/c/9511/1/main/stasis.c@1203
PS1, Line 1203: 		ast_log(LOG_WARNING, "Use of %s() while in declined list\n", name);
I think we don't even need to do a warning myself, I think no message at all if it is in the decline list is fine.



-- 
To view, visit https://gerrit.asterisk.org/9511
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 15
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0d866d1cbc60c16dbef08bc65e99505c3c1adfa
Gerrit-Change-Number: 9511
Gerrit-PatchSet: 1
Gerrit-Owner: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Jenkins2
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 18 Jul 2018 16:59:21 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20180718/3eaf78cd/attachment.html>


More information about the asterisk-code-review mailing list